Skip to content

REF/TST: share asfreq tests #44219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

REF/TST: share asfreq tests #44219

merged 1 commit into from
Oct 29, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

simonjayhawkins
simonjayhawkins reviewed Oct 29, 2021
View reviewed changes
pandas/tests/frame/methods/test_asfreq.py
@@ -15,41 +17,135 @@


class TestAsFreq:
def test_asfreq_resample_set_correct_freq(self):
def test_asfreq2(self, frame_or_series):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you avoid the "2" here and be more descriptive

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im open to suggestions. there are a lot of places with e.g. "# TODO: more informative test name"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah let's do in a followup is fine.

@simonjayhawkins simonjayhawkins added Frequency DateOffsets Testing pandas testing functions or related to the test suite labels Oct 29, 2021
@simonjayhawkins simonjayhawkins added this to the 1.4 milestone Oct 29, 2021
@jreback jreback merged commit 2fa2d5c into pandas-dev:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

Assignees
No one assigned
Labels
Frequency DateOffsets Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @simonjayhawkins