Skip to content

update astype keyerror msg #44487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2021
Merged

update astype keyerror msg #44487

merged 2 commits into from
Nov 20, 2021

Conversation

endremborza
Copy link
Contributor

@endremborza endremborza commented Nov 16, 2021 •
edited
Loading

Hi!

This is extremely minor and i just quickly did it in codespaces but I ran into this a few times and I thought it might be helpful for others.

phofl
phofl reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc build is failing, related?

Also could you add a test testing for the specific message?

@phofl
Copy link
Member

phofl commented Nov 17, 2021

Docs failure is not related

@jreback jreback added the Error Reporting Incorrect or improved errors from pandas label Nov 20, 2021
@jreback jreback added this to the 1.4 milestone Nov 20, 2021
@jreback jreback merged commit 1b887ec into pandas-dev:master Nov 20, 2021
@jreback
Copy link
Contributor

jreback commented Nov 20, 2021

thanks @endremborza

@dannyi96 dannyi96 mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@endremborza @phofl @jreback