Skip to content

REF: standardize __array_ufunc__ patterns #45113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2021
Merged

REF: standardize __array_ufunc__ patterns #45113

merged 2 commits into from
Dec 30, 2021

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Dec 29, 2021 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

The idea here is to get all of our __array_ufunc__ implementations to use all of the helpers, at which point we can just combine them all into one helper.

@jreback jreback added Refactor Internal refactoring of code Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Dec 30, 2021
@jreback jreback added this to the 1.4 milestone Dec 30, 2021
@jreback jreback merged commit e72027d into pandas-dev:master Dec 30, 2021
@jbrockmendel jbrockmendel deleted the cln-array_wrap branch December 30, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback