Skip to content

BUG: Make xticks from _quarterly_finder() line up better #47602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 15, 2022
+34 −1
Merged

BUG: Make xticks from _quarterly_finder() line up better #47602

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c68ac4f
Make xticks from _quarterly_finder() line up better
elidourado Jul 5, 2022
53e33eb
Create test for _quarterly_finder()
elidourado Jul 6, 2022
df240a5
Shorten comment
elidourado Jul 6, 2022
566edbb
Style refinements
elidourado Jul 6, 2022
db35957
Style
elidourado Jul 6, 2022
70dbb71
Sort imports
elidourado Jul 6, 2022
9640e3c
Simplify test and move to test_converter.py file
elidourado Jul 11, 2022
1556507
Newline at end of file
elidourado Jul 11, 2022
fcbc9b3
Make 4 individual asserts
elidourado Jul 14, 2022
dc4bec8
Add Github discussion link as comment
elidourado Jul 14, 2022
eeb696c
Remove newline from end of file
elidourado Jul 15, 2022
3bebe4c
Replace newline at end of file (minus tab)
elidourado Jul 15, 2022
aa7aa40
Add one line of white space
elidourado Jul 15, 2022
895f69e
Added release note in bug fixes/visualization section
elidourado Jul 15, 2022
d5a5ffb
Moved release note to different section and noted public method
elidourado Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/plotting/_matplotlib/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,7 @@ def _quarterly_finder(vmin, vmax, freq):
info_fmt[year_start] = "%F"

else:
years = dates_[year_start] // 4 + 1
years = dates_[year_start] // 4 + 1970
nyears = span / periodsperyear
(min_anndef, maj_anndef) = _get_default_annual_spacing(nyears)
major_idx = year_start[(years % maj_anndef == 0)]
Expand Down