STYLE enable pylint: non-parent-init-called #49819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
62
to
+63
| # Do not call LinePlot.__init__ which may fill nan | ||
| MPLPlot.__init__(self, data, **kwargs) | ||
| MPLPlot.__init__(self, data, **kwargs) # pylint: disable=non-parent-init-called |
There was a problem hiding this comment.
this comment is useful - for the other two cases, can we move the comment to be directly above the MPLPlot.__init__ line (or add it there if it's not already present, as in the Kdeplot case?)
There was a problem hiding this comment.
Thanks, @MarcoGorelli . I added comments as you suggested.
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* STYLE enable pylint: non-parent-init-called * fixup! STYLE enable pylint: non-parent-init-called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #48855. This PR enables pylint type "W" warning:
non-parent-init-called