Skip to content

DEPR/API: DataFrame.shift(axis=1, fill_value=inty) #49842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 23, 2022
Merged

DEPR/API: DataFrame.shift(axis=1, fill_value=inty) #49842

merged 4 commits into from
Nov 23, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

mroeschke
mroeschke reviewed Nov 23, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a merge conflict

@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Nov 23, 2022
rhshadrach
rhshadrach approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added the Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff label Nov 23, 2022
@rhshadrach rhshadrach added this to the 2.0 milestone Nov 23, 2022
@rhshadrach rhshadrach merged commit beab917 into pandas-dev:main Nov 23, 2022
@rhshadrach
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-shift branch November 23, 2022 02:52
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@jbrockmendel @mliu08
DEPR/API: DataFrame.shift(axis=1, fill_value=inty) (pandas-dev#49842)
0a5f479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @rhshadrach @mroeschke