Min max added to reduction ops

[ShisuiUzumaki]

• closes BUG: query(engine='numexpr') not work correctly when column name is 'max' or 'min'. #50937
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added type annotations to new arguments/methods/functions.
• Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

[ShisuiUzumaki]

Can someone from pandas team review this?

[mroeschke]

Needs tests and a whatsnew note in v2.0.0.rst

[ShisuiUzumaki]

Needs tests and a whatsnew note in v2.0.0.rst

Could you give some pointers on how can I add these tests and whatsnew

[mroeschke]

A unit test that checks the behavior of the related issue be added to pandas/tests/frame/test_query_eval.py.

An entry should be added to doc/source/whatsnew/v2.0.0.rst describing what was fixed

[ShisuiUzumaki]

A unit test that checks the behavior of the related issue be added to pandas/tests/frame/test_query_eval.py.

An entry should be added to doc/source/whatsnew/v2.0.0.rst describing what was fixed

Would the following test be okay?

class TestDataFrameQueryNumExprPython(TestDataFrameQueryNumExprPandas):

    ...

    def test_query_numexpr_with_min_and_max_columns(self):
        df = DataFrame({"min": [1, 2, 3], "max": [4, 5, 6]})
        regex_to_match = r"Variables in expression \"\(min\) == \(1\)\" overlap with builtins: \('min'\)"
        with pytest.raises(NumExprClobberingError, match=regex_to_match):
            df.query("min == 1")

        regex_to_match = r"Variables in expression \"\(max\) == \(1\)\" overlap with builtins: \('max'\)"
        with pytest.raises(NumExprClobberingError, match=regex_to_match):
            df.query("max == 1")

[mroeschke]

Yes but the tests can just be stand alone functions

[ShisuiUzumaki]

An entry should be added to doc/source/whatsnew/v2.0.0.rst describing what was fixed

Also, could you give me some more hints on what format I should follow to add changes descriptions in
doc/source/whatsnew/v2.0.0.rst? Like in what section, what should be the phrasing format, etc.

Is this ok:

Numeric
^^^^^^^

• Bug in :meth:query with engine="numexpr" and column names are min or max, does not work correctly (:issue:50937)

[mroeschke]

This will be easier to comment on if you commit the changes you suggested

[ShisuiUzumaki]

This will be easier to comment on if you commit the changes you suggested

Sure!

[mroeschke]

************* Module pandas.tests.frame.test_query_eval
pandas/tests/frame/test_query_eval.py:540:8: W0404: Reimport 'NumExprClobberingError' (imported line 6) (reimported)

[mroeschke]

Thanks @ShisuiUzumaki