CLN: Enable codespell for all files #51804
Merged
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks doesn't look like it codespell...............................................................................................Failed
- hook id: codespell
- duration: 1.66s
- exit code: 65
pandas/tests/io/data/xml/cta_rail_lines.kml:14: fo ==> of, for, to, do, go
pandas/tests/io/data/xml/cta_rail_lines.kml:14: DESCRIPTIO ==> DESCRIPTION
pandas/tests/io/data/xml/cta_rail_lines.kml:27: fo ==> of, for, to, do, go
pandas/tests/io/data/xml/cta_rail_lines.kml:27: DESCRIPTIO ==> DESCRIPTION
pandas/tests/io/data/xml/cta_rail_lines.kml:40: fo ==> of, for, to, do, go
pandas/tests/io/data/xml/cta_rail_lines.kml:40: DESCRIPTIO ==> DESCRIPTION
pandas/tests/io/data/xml/cta_rail_lines.kml:53: fo ==> of, for, to, do, go
pandas/tests/io/data/xml/cta_rail_lines.kml:53: DESCRIPTIO ==> DESCRIPTION
pandas/tests/io/data/xml/cta_rail_lines.kml:66: fo ==> of, for, to, do, go
pandas/tests/io/data/xml/cta_rail_lines.kml:66: DESCRIPTIO ==> DESCRIPTION
pandas/_libs/src/ujson/lib/ultrajson.h:190: iteratable ==> iterable
pandas/_libs/src/ujson/lib/ultrajson.h:202: iteratable ==> iterable
pandas/_libs/testing.pyx:190: ambigous ==> ambiguous
pandas/_libs/src/parser/tokenizer.c:1831: housand ==> thousand
pandas/_libs/ops_dispatch.pyx:94: nin ==> inn, min, bin, nine
pandas/_libs/missing.pyx:55: ambigous ==> ambiguous
pandas/_libs/tslibs/strptime.pyx:3: TimeRE ==> timer
pandas/_libs/tslibs/strptime.pyx:11: TimeRE ==> timer
pandas/_libs/tslibs/strptime.pyx:28: TimeRE ==> timer
pandas/_libs/tslibs/strptime.pyx:236: TimeRE ==> timer
pandas/_libs/tslibs/strptime.pyx:536: TimeRE ==> timer
pandas/_libs/tslibs/strptime.pyx:552: TimeRE ==> timer
pandas/_libs/tslibs/strptime.pyx:562: TimeRE ==> timer
pandas/_libs/tslibs/strptime.pyx:571: TimeRE ==> timer
pandas/_libs/hashing.pyx:58: datas ==> data
pandas/_libs/hashing.pyx:100: datas ==> data
web/pandas/config.yml:161: dfine ==> define
WARNING: Decoding file using encoding=utf-8 failed: pandas/tests/io/data/xml/baby_names.xml
WARNING: Trying next encoding iso-8859-1
pandas/_libs/lib.pyx:2653: becase ==> because
pandas/_libs/tslibs/timestamps.pyx:2347: overriden ==> overridden
pandas/_libs/tslibs/timestamps.pyx:2357: overriden ==> overridden
pyproject.toml:276: indendation ==> indentation
pandas/_libs/tslibs/timedeltas.pyx:1109: overrided ==> overrode, overriddenhow did you run it locally? it should be |
MarcoGorelli
reviewed
Mar 6, 2023
.pre-commit-config.yaml
Outdated
Comment on lines
45
to
51
| types_or: [python, rst, markdown] | ||
| exclude: | | ||
| (?x) | ||
| pandas/tests/io/data/xml | ||
| |pandas/_libs/ops_dispatch.pyx | ||
| |pandas/_libs/tslibs/strptime | ||
| |web/pandas/config.yml | ||
|
|
There was a problem hiding this comment.
how about expanding types_or instead of excluding certain files? cython and c should probably be in there
There was a problem hiding this comment.
Thanks for so fast replay!
We should add cython and c, instead of exclude some files?
|
I forgot to run it with I make some changes, but some of them may not suitable. I am open to any suggestions or advice. |
MarcoGorelli
reviewed
Mar 6, 2023
.pre-commit-config.yaml
Outdated
| types_or: [python, rst, markdown, cython, c] | ||
| exclude: | | ||
| (?x) | ||
| |pandas/_libs/ops_dispatch.pyx |
There was a problem hiding this comment.
nin cause error, same as TimeRE
There was a problem hiding this comment.
should I add some comment to explain them?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems works fine in current main branch.