Skip to content

PERF: Improve performance for arrow engine and dtype_backend=pyarrow for datetime conversion #52548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2023
Merged

PERF: Improve performance for arrow engine and dtype_backend=pyarrow for datetime conversion #52548

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c048abf
PERF: Improve performance for arrow engine and dtype_backend=pyarrow …
phofl Apr 8, 2023
30cf277
Fix
phofl Apr 8, 2023
789a3cf
Fix
phofl Apr 8, 2023
fc86c59
Update
phofl Apr 10, 2023
c97b8c5
Add whatsnew
phofl Apr 10, 2023
a40f459
Add whatsnew
phofl Apr 10, 2023
f71c512
Merge branch 'main' into 52546
phofl Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions asv_bench/benchmarks/io/csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,4 +555,19 @@ def time_read_csv_index_col(self):
read_csv(self.StringIO_input, index_col="a")


class ReadCSVDatePyarrowEngine(StringIORewind):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fuse this benchmark with ReadCSVParseDates above?
(You might have to disable time_multiple_dates for the pyarrow engine)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer keeping them separate for now since I am expecting to add more arrow versions that aren't really compatible with the others.

def setup(self):
count_elem = 100_000
data = "a\n" + "2019-12-31\n" * count_elem
self.StringIO_input = StringIO(data)

def time_read_csv_index_col(self):
read_csv(
self.StringIO_input,
parse_dates=["a"],
engine="pyarrow",
dtype_backend="pyarrow",
)


from ..pandas_vb_common import setup # noqa: F401 isort:skip
12 changes: 12 additions & 0 deletions pandas/io/parsers/base_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
)
from pandas.core.dtypes.missing import isna

import pandas as pd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we just import ArrowDtype below instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

from pandas import (
DatetimeIndex,
StringDtype,
Expand Down Expand Up @@ -867,6 +868,7 @@ def _do_date_conversions(
self.index_names,
names,
keep_date_col=self.keep_date_col,
dtype_backend=self.dtype_backend,
)

return names, data
Expand Down Expand Up @@ -1203,6 +1205,7 @@ def _process_date_conversion(
index_names,
columns,
keep_date_col: bool = False,
dtype_backend=lib.no_default,
):
def _isindex(colspec):
return (isinstance(index_col, list) and colspec in index_col) or (
Expand All @@ -1228,6 +1231,15 @@ def _isindex(colspec):
colspec = orig_names[colspec]
if _isindex(colspec):
continue
elif dtype_backend == "pyarrow":
import pyarrow as pa

dtype = data_dict[colspec].dtype
if isinstance(dtype, pd.ArrowDtype) and pa.types.is_timestamp(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to keep date types too i.e. pa.types.is_date

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

dtype.pyarrow_dtype
):
continue

# Pyarrow engine returns Series which we need to convert to
# numpy array before converter, its a no-op for other parsers
data_dict[colspec] = converter(
Expand Down