Skip to content

TYP: some typing in internals/concat.py #52581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2023
Merged

TYP: some typing in internals/concat.py #52581

merged 2 commits into from
Apr 11, 2023

Conversation

topper-123
Copy link
Contributor

Some typing.

jbrockmendel
jbrockmendel reviewed Apr 10, 2023
View reviewed changes
@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Apr 10, 2023
jbrockmendel
jbrockmendel approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrockmendel jbrockmendel merged commit 3eef165 into pandas-dev:main Apr 11, 2023
@jbrockmendel
Copy link
Member

thanks @topper-123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@topper-123 @jbrockmendel @mroeschke