Skip to content

ENH: ValueError when to_sql() receives empty name param #52675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2023
Merged

ENH: ValueError when to_sql() receives empty name param #52675

merged 4 commits into from
Apr 17, 2023

Conversation

StefanieSenger
Copy link
Contributor

@StefanieSenger StefanieSenger commented Apr 14, 2023 •
edited
Loading

@mroeschke mroeschke added the IO SQL to_sql, read_sql, read_sql_query label Apr 14, 2023
mroeschke
mroeschke reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Needs a test and a whatsnew entry in v2.1.0.rst

@StefanieSenger
Copy link
Contributor Author

StefanieSenger commented Apr 15, 2023 •
edited
Loading

Thanks for the hints. I've added a test and an entry in "what's new". If there's anything I can improve just drop me a line. I'm a bit new to this.

@mroeschke mroeschke added this to the 2.1 milestone Apr 17, 2023
@mroeschke mroeschke merged commit e7343f7 into pandas-dev:main Apr 17, 2023
@mroeschke
Copy link
Member

Thanks @StefanieSenger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

ENH: Clearer error messaging when pd.DataFrame.to_sql() receives an empty string for name param
2 participants
@StefanieSenger @mroeschke