Skip to content

Fix typo in future warning message #52889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

Fix typo in future warning message #52889

merged 1 commit into from
Apr 24, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Apr 24, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl requested a review from rhshadrach April 24, 2023 08:10
MarcoGorelli
MarcoGorelli approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @phofl

@MarcoGorelli MarcoGorelli added this to the 2.0.2 milestone Apr 24, 2023
@MarcoGorelli MarcoGorelli added the Warnings Warnings that appear or should be added to pandas label Apr 24, 2023
@phofl phofl modified the milestones: 2.0.2, 2.1 Apr 24, 2023
@phofl
Copy link
Member Author

phofl commented Apr 24, 2023

This is only on 2.1, run into this in Dask

@mroeschke mroeschke merged commit 2613ad8 into pandas-dev:main Apr 24, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the typo_docs branch April 24, 2023 18:53
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
@phofl
Fix typo in future warning message (pandas-dev#52889)
d430a98
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@phofl
Fix typo in future warning message (pandas-dev#52889)
063be94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

Assignees
No one assigned
Labels
Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @mroeschke @MarcoGorelli