DOC: Adds the PDEP vote issue template #54469
Conversation
There was a problem hiding this comment.
I'm fine with the proposed template, but shouldn't we just do this by creating an issue template at https://github.com/pandas-dev/pandas/tree/main/.github/ISSUE_TEMPLATE rather than documenting the template contents here?
|
Do we mind that it means anyone could use it, even though they needn't?! |
Might be worth getting the opinion of others. Don't want to tag - you could just ask at the sprint! |
|
I would be in favor of making it an issue template for future convenience. I think you can specify the purpose of each issue template too so that it won't be likely for others to select it. |
|
Awesome - thanks for the input. I'll adjust it then. |
noatamir
changed the title
|
First stab at an issue template. Anyone knows a way to preview them? |
|
The only way I've found to preview is to push the change to your fork an inspect from your repo. |
Is there a way that we as reviewers can see how the template would be rendered? @noatamir Separately, if I go to https://github.com/noatamir/pandas/blob/vote_issue_template/.github/ISSUE_TEMPLATE/pdep_vote.yaml there is a message at the top that says "body[6]: validations is not a permitted attribute." |
I don't think there is besides copying the changes to your own fork :/ |
So if I do that, how can I then see the rendered issue template? When I go to my forks, I don't have any issue tab (and maybe I have to do something to create it??) |
@noatamir in your fork of the repo, if you turn on "issues" in "Settings", then the new template should show up if we try to create an issue in your repo, which would allow us to preview the template |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Going to close this for now due to inactivity, but we can reopen at any time |
|
@mroeschke I'd like to keep this open. @noatamir has been affected by the events in Israel, so hopefully she will be available soon to resume this work. |
|
#53576 has been merged, may I attempt to continue the work on this? |
Yes, you can take it over. See comments above (#54469 (comment)) about how we can look at how the template is rendered. |
|
Closed by #58204 |
This template will facilitate changes currently proposed in #53576.
Recommend merging it after #53576 is approved. Opened now to facilitate ongoing PDEP voting work.
Also adding PDEP to rst capitalization exception list.