Updated ruff pre-commit version and modified few lines according to it.
#54639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mroeschke sir, can you please review the PR, Thank you. |
twoertwein
reviewed
Aug 19, 2023
| @@ -903,7 +903,7 @@ def _list_of_dict_to_arrays( | |||
|
|
|||
| # assure that they are of the base dict class and not of derived | |||
| # classes | |||
| data = [d if type(d) is dict else dict(d) for d in data] | |||
| data = [d if type(d) is dict else dict(d) for d in data] # noqa: E721 | |||
There was a problem hiding this comment.
Instead of ignoring the issue, maybe try [d if isinstance(d, dict) ...]?
edit: The comment suggests that it needs to be a dict and not a subclass
There was a problem hiding this comment.
@twoertwein yes, sir. So, I guess there is nothing I need to change?
mroeschke
approved these changes
Aug 21, 2023
|
Thanks @Sai-Suraj-27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff 0.0.285 has been released (https://github.com/astral-sh/ruff-pre-commit).
So, I have updated the ruff version in
.pre-commit-config.yamlfile, ranruff .and corrected few files according to the errors it showed.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.