Skip to content

TST: fix cumcount test on 32-bit env #5540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2013

Conversation

gdraps
Copy link
Contributor

@gdraps gdraps commented Nov 18, 2013

Fix test_groupby.test_cumcount_empty() on 32-bit platforms by specifying expected dtype of 'int64'.

======================================================================
FAIL: test_cumcount_empty (pandas.tests.test_groupby.TestGroupBy)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/gmd/github_shadow/pandas/pandas/tests/test_groupby.py", line 2579, in test_cumcount_empty
    assert_series_equal(e, ge.cumcount())
  File "/home/gmd/github_shadow/pandas/pandas/util/testing.py", line 423, in assert_series_equal
    assert_attr_equal('dtype', left, right)
  File "/home/gmd/github_shadow/pandas/pandas/util/testing.py", line 407, in assert_attr_equal
    assert_equal(left_attr,right_attr,"attr is not equal [{0}]" .format(attr))
  File "/home/gmd/github_shadow/pandas/pandas/util/testing.py", line 390, in assert_equal
    assert a == b, "%s: %r != %r" % (msg.format(a,b), a, b)
AssertionError: attr is not equal [dtype]: dtype('int32') != dtype('int64')

@jtratner
Copy link
Contributor

We should add a note about using int64 instead of int. Not that it will
necessarily resolve this completely.

jtratner added a commit that referenced this pull request Nov 18, 2013
TST: fix cumcount test on 32-bit env
@jtratner jtratner merged commit 4d0632b into pandas-dev:master Nov 18, 2013
@jtratner
Copy link
Contributor

Thanks for catching this! I'm hoping we can get an automatic 32bit build from Travis at some point.

@gdraps
Copy link
Contributor Author

gdraps commented Nov 18, 2013

Thanks Jeff.. For completeness, here's the open issue tracking 32-bit env support in Travis: travis-ci/travis-ci#986

@gdraps gdraps deleted the cumcount-test-fix branch November 18, 2013 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants