BUG: infer_string not inferring string dtype when NA is first value #55655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Strings
WillAyd
reviewed
Oct 23, 2023
There was a problem hiding this comment.
@lithomas1 was looking at this function recently. Might want to review as well
| @@ -2665,6 +2665,8 @@ def maybe_convert_objects(ndarray[object] objects, | |||
| else: | |||
| seen.object_ = True | |||
| break | |||
| elif val is C_NA: | |||
| seen.object_ = True | |||
There was a problem hiding this comment.
I think missing a break after this? See it in all the other branches at least
There was a problem hiding this comment.
No this is missing on purpose. We don't know which dtype we have with NA and infer-string set, so have to do another pass
There was a problem hiding this comment.
Ah OK. Does continue work here too? Assuming no difference with the current code setup, but continue would be more future-proof in case of a refactor, while also signaling intent
lithomas1
approved these changes
Oct 24, 2023
|
thanks @phofl. |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 24, 2023
…dtype when NA is first value
phofl
added a commit
that referenced
this pull request
Oct 24, 2023
…tring dtype when NA is first value) (#55666) Backport PR #55655: BUG: infer_string not inferring string dtype when NA is first value Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.