remove ctypedef class from lib.pyx #56018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ah ok. I guess this makes it so dtype is not a Python object, so probably need to change that check around |
mroeschke
added
the
Internals
mroeschke
reviewed
Nov 17, 2023
pandas/_libs/lib.pyx
Outdated
| @@ -1961,7 +1945,7 @@ cdef class BytesValidator(Validator): | |||
| return isinstance(value, bytes) | |||
|
|
|||
| cdef bint is_array_typed(self) except -1: | |||
| return issubclass(self.dtype.type, np.bytes_) | |||
| return self.dtype.type == cnp.NPY_BYTE or self.dtype.type == cnp.NPY_UBYTE | |||
There was a problem hiding this comment.
cc @seberg is this the right way to check for bytes?
There was a problem hiding this comment.
No, its NPY_STRING (string is NPY_UNICODE, leftover from python 2)
seberg
reviewed
Nov 17, 2023
pandas/_libs/lib.pyx
Outdated
| @@ -1944,7 +1928,7 @@ cdef class StringValidator(Validator): | |||
| return isinstance(value, str) | |||
|
|
|||
| cdef bint is_array_typed(self) except -1: | |||
| return issubclass(self.dtype.type, np.str_) | |||
| return cnp.PyDataType_ISSTRING(self.dtype) | |||
There was a problem hiding this comment.
So this is also wrong, ISSTRING checks for bytes (NPY_STRING) OR unicode. You want == NPY_UNICODE here if you use this.
mroeschke
approved these changes
Nov 17, 2023
|
Thanks @WillAyd |
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbrockmendel