Skip to content

BLD: fixup setup.py, initialize pipe variable to None #5868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from Jan 7, 2014
Merged

BLD: fixup setup.py, initialize pipe variable to None #5868

1 commit merged into from Jan 7, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2014

recent changes (fe9c0ae) broke setup.py for some users:

#5867 (comment)

@jreback
Copy link
Contributor

jreback commented Jan 7, 2014

ironically their is not an easy way to do this if you are a user. iow, you use git to clone the dir, then uninstall git????
or copy a cloned dir to another machine. weird.

@ghost
Copy link
Author

ghost commented Jan 7, 2014

Actually, I completely botched this... there used to be a defensive try/except which swallowed this.
users that get a straight tarball are affected by this, and I'm afraid that means 0.13.0 is borked
as well for users who don't have git installed.

Windows users usually install binaries and others that use tarball will almost always have git
installed so not a complete clusterf**k.

never ever change working code. In fact, never write code. it always ends badly.

and naturally, the windows CI box has git installed... so this slipped through. sigh

@jreback
Copy link
Contributor

jreback commented Jan 7, 2014

didnt' you change this after 0.13? 7c6e5f6

@ghost
Copy link
Author

ghost commented Jan 7, 2014

oh yeah, fooled by commit log ordered by author date rather then commit date.
I remember now, I waited till 0.13.0 to merge. Release paranoia wins out again.

ghost pushed a commit that referenced this pull request Jan 7, 2014
BLD: fixup setup.py, initialize pipe variable to None
@ghost ghost merged commit e23bd2c into pandas-dev:master Jan 7, 2014
@ghost ghost deleted the PR_setup_pipe branch January 7, 2014 19:25
@ghost
Copy link
Author

ghost commented Jan 7, 2014

thanks for the report @ruidc

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant