BUG: use astype for scipy datetime interpolation #5998
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this might break for a PeriodIndex getattr(x,'is_all_dates',False) instead of doing isinstance which will catch both types of indexes |
|
Thanks, I forgot about PeriodIndices. There's no need for a release notes entry right? |
|
nope |
ghost
pushed a commit
that referenced
this pull request
Jan 19, 2014
BUG: use astype for scipy datetime interpolation
ghost
merged commit 
|
Thanks, added a regression test. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5975 (again), with the issue raised at #5977 (comment).
I'm using
astypeinstead ofviewnow, as Jeff suggested. I also didn't realize thatasi8was a method on allIndexes, and not justDatetimeIndexes. So instead of checking for that attr, I just check if it's a DatetimeIndex.@y-p this should fix the doc example. It built for me anyway, but I've had trouble building the docs off my working branch.