Skip to content

DOC: Clarify that DataFrame string formatters must return strings #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2014

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Jan 23, 2014

I am not 100% sure that string formatters must really return unicode strings
(non-unicode strings seem to work, too), but I am leaving that because it's
what is already documented.
related #6052

I am not 100% sure that string formatters must really return *unicode* strings
(non-unicode strings seem to work, too), but I am leaving that because it's
what is already documentated.

Fixes pandas-dev#6052.
@hayd
Copy link
Contributor

hayd commented Jan 27, 2014

Disagree this "fixes" 6052, but it does help! I wonder if there is a good place in the docs to add more about this?

I think probably we should catch bad input and re-raise it with better message... accepting string e.g. '%0.f' would also be nice.

@jreback jreback added the Docs label Feb 14, 2014
@jreback jreback added this to the 0.14.0 milestone Feb 14, 2014
jreback added a commit that referenced this pull request Feb 14, 2014
DOC: Clarify that DataFrame string formatters must return strings
@jreback jreback merged commit 186491f into pandas-dev:master Feb 14, 2014
@jreback
Copy link
Contributor

jreback commented Feb 14, 2014

ok...will leave open #6052

@shoyer thanks for the investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants