Skip to content

BLD: Build wheels for 3.9 and musllinux-aarch64 for pandas 2.3 #61569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

BLD: Build wheels for 3.9 and musllinux-aarch64 for pandas 2.3 #61569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbb5368
BLD: Build wheels for 3.9
mroeschke Jun 5, 2025
0d5d873
Add musllinux arch as well
mroeschke Jun 5, 2025
f06f0cc
hardcode version for meson
mroeschke Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,13 @@ jobs:
- [ubuntu-22.04, manylinux_x86_64]
- [ubuntu-22.04, musllinux_x86_64]
- [ubuntu-24.04-arm, manylinux_aarch64]
- [ubuntu-24.04-arm, musllinux_aarch64]
- [macos-13, macosx_x86_64]
# Note: M1 images on Github Actions start from macOS 14
- [macos-14, macosx_arm64]
- [windows-2022, win_amd64]
# TODO: support PyPy?
python: [["cp310", "3.10"], ["cp311", "3.11"], ["cp312", "3.12"], ["cp313", "3.13"], ["cp313t", "3.13"]]
python: [["cp39", "3.9"], ["cp310", "3.10"], ["cp311", "3.11"], ["cp312", "3.12"], ["cp313", "3.13"], ["cp313t", "3.13"]]
include:
# TODO: Remove this plus installing build deps in cibw_before_build.sh
# after pandas can be built with a released NumPy/Cython
Expand Down
2 changes: 1 addition & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
project(
'pandas',
'c', 'cpp', 'cython',
version: run_command(['generate_version.py', '--print'], check: true).stdout().strip(),
version: '2.3.0',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lithomas1 so I'm just trying to upload the 3.9 packages with twine from this PR, and originally I'm getting

The use of local versions in <Version('2.3.0+3.g313260cf75')> is not allowed

So I'm guessing this line is adding the extra git hash in the metadata. Do you know if I'll need to hard code the version elsewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of using versioneer here (https://github.com/pandas-dev/pandas/pull/61569/files#diff-30d8f6be6320feeacf686be94f48c70869b52630e01ea625f0f15adc0d57c3e4R31-R45), we can hardcode the _version_meson.py file using a shell script or command or something.

It's been a while but I think the file just outputs a __version__ and __git_version__ variable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wheel build when hardcoding this produced wheels with a version twine accepted so I guess this worked 🤷 https://pypi.org/project/pandas/2.3.0/#files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll take it :).

license: 'BSD-3',
meson_version: '>=1.2.1',
default_options: [
Expand Down
Loading