Skip to content

Fix edge count prompt #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Fix edge count prompt #43

merged 1 commit into from
May 8, 2025

Conversation

Dando18
Copy link
Member

@Dando18 Dando18 commented May 8, 2025

closes #39

@Dando18 Dando18 requested a review from Copilot May 8, 2025 17:45
@Dando18 Dando18 self-assigned this May 8, 2025
@Dando18 Dando18 added bug Something isn't working ready-for-review labels May 8, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the expected output in the prompt examples for the edge count function from 3 to 6 across various parallelism models and test drivers. The change ensures consistency between the prompt documentation and the underlying expected behavior.

  • Updated expected output from 3 to 6 in all prompt examples.
  • Modified prompt definitions in the JSON generation file.
  • Adjusted the baseline test file to reflect the new output.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
prompts/raw/graph/15_graph_edge_count/serial Updated output from 3 to 6 in the serial prompt.
prompts/raw/graph/15_graph_edge_count/omp Updated output from 3 to 6 in the OpenMP prompt.
prompts/raw/graph/15_graph_edge_count/mpi+omp Updated output from 3 to 6 in the MPI+OMP prompt.
prompts/raw/graph/15_graph_edge_count/mpi Updated output from 3 to 6 in the MPI prompt.
prompts/raw/graph/15_graph_edge_count/kokkos Updated output from 3 to 6 in the Kokkos prompt.
prompts/raw/graph/15_graph_edge_count/hip Updated output from 3 to 6 in the HIP prompt.
prompts/raw/graph/15_graph_edge_count/cuda Updated output from 3 to 6 in the CUDA prompt.
prompts/generation-prompts.json Reflected updated output of 6 for all models.
drivers/cpp/benchmarks/graph/15_graph_edge_count/baseline.hpp Updated baseline test expected output to 6.

@Dando18 Dando18 merged commit 9a9220b into develop May 8, 2025
@Dando18 Dando18 deleted the fix-edge-count-prompt branch May 8, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Definition/Example : Graph - Graph Edge Count
1 participant