Skip to content

gradle update + dependencies updates + minor changes #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

gradle update + dependencies updates + minor changes #1131

wants to merge 16 commits into from

Conversation

mobilekosmos
Copy link

@mobilekosmos mobilekosmos commented Oct 16, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

Related issue: #FILL_THIS_OUT

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 16, 2021 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please check all required checkboxes at the top, otherwise your pull request will be closed.

  • ⚠️ Remember that a security vulnerability must only be reported confidentially, see our Security Policy. If you are not sure whether the issue is a security vulnerability, the safest way is to treat it as such and submit it confidentially to us for evaluation.

@mobilekosmos mobilekosmos changed the title Gradle update + dependencies updates + minor changes. gradle update + dependencies updates + minor changes Oct 16, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 21, 2021 •
edited
Loading

@mobilekosmos could you add a description to this PR and resolve the conflicts, so we can get this ready for review?

@mobilekosmos
Copy link
Author

mobilekosmos commented Oct 21, 2021 •
edited
Loading

I suppose the conflicts happened after my PR since I started a new fresh PR because of prior conflicts and many changes.
What description? The title already describes the work I did? The few dependencies I remoevd were already discussed/asked for in the old PR, they were removed because not used/not needed anymore.
I resolved the conflicts.

@mobilekosmos
Update build.gradle
4a61404 
Reverted conflict resolution wrong deletion of buildConfigField("String","PARSE_VERSION","\"${version}\"")
@mobilekosmos
Update build.gradle
d75dd9f 
Reverted conflict resolution wrong deletion of buildConfigField("String","PARSE_VERSION","\"${version}\"")
@mobilekosmos
Update build.gradle
4af26ee 
Reverted conflict resolution wrong deletion of buildConfigField("String","PARSE_VERSION","\"${version}\"")
@mtrezza
Copy link
Member

mtrezza commented Oct 21, 2021 •
edited
Loading

Others will have a hard time understanding what this PR is about without looking into the code. To make this easier we have a PR template. See this.

There is also a min API bump to 21, which is a breaking change. It helps the committer a lot if you clearly indicate a breaking change in the PR description. This helps to make sure that a breaking change is marked as such in the changelog.

@mtrezza
Copy link
Member

mtrezza commented Nov 18, 2021

I am closing this as it lacks information about the issue that this PR intends to solve. Feel free to comment if you have any questions and we can re-open this PR.

@mtrezza mtrezza closed this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mobilekosmos @mtrezza