Skip to content

Implementing Parcelable in ParseGeoPoint #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2017

Conversation

natario1
Copy link
Contributor

@natario1 natario1 commented Apr 3, 2017

As per title. It’s the easiest step in bringing Parcelable into the SDK.

@facebook-github-bot
Copy link

@natario1 updated the pull request - view changes

@rogerhu
Copy link
Contributor

rogerhu commented Apr 3, 2017

Can I ask though what's the overall plan? #122

@natario1
Copy link
Contributor Author

natario1 commented Apr 3, 2017

@rogerhu from #122 I think it’s common wish to eventually implement Parcelable to ParseObject, no?
But since ParseObject hosts other objects, we must first make these Parcelable (e.g. ParseGeoPoint, ParseFile).

I have it working for ParseFile as well and can PR.

I’ll open up an issue with some thoughts now.

@rogerhu
Copy link
Contributor

rogerhu commented Apr 3, 2017

See also #557

This was referenced Apr 3, 2017
@rogerhu
Copy link
Contributor

rogerhu commented Apr 19, 2017

rebase

@codecov
Copy link

codecov bot commented Apr 19, 2017

Codecov Report

Merging #619 into master will increase coverage by 0.05%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #619      +/-   ##
============================================
+ Coverage     52.52%   52.58%   +0.05%     
- Complexity     1659     1664       +5     
============================================
  Files           131      131              
  Lines         10121    10138      +17     
  Branches       1407     1407              
============================================
+ Hits           5316     5331      +15     
- Misses         4365     4368       +3     
+ Partials        440      439       -1
Impacted Files Coverage Δ Complexity Δ
Parse/src/main/java/com/parse/ParseFile.java 77.77% <ø> (ø) 43 <0> (ø) ⬇️
...se/src/main/java/com/parse/ParseParcelEncoder.java 87.69% <100%> (+3.31%) 20 <0> (+1) ⬆️
...se/src/main/java/com/parse/ParseParcelDecoder.java 87.87% <100%> (+0.37%) 31 <0> (+2) ⬆️
Parse/src/main/java/com/parse/ParseGeoPoint.java 63.23% <73.33%> (+2.85%) 11 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46a0233...9ac8589. Read the comment docs.

@natario1
Copy link
Contributor Author

@rogerhu this is ready as well. I think we can close #122

@rogerhu rogerhu merged commit 6223d06 into parse-community:master Apr 20, 2017
@natario1 natario1 deleted the parcelable-point branch May 1, 2017 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants