Skip to content

Bug fixes: add synchronized block to map operation in OfflineStore #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2017

Conversation

hermanliang
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 8, 2017

Codecov Report

Merging #659 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #659      +/-   ##
============================================
+ Coverage     52.85%   52.86%   +<.01%     
  Complexity     1676     1676              
============================================
  Files           131      131              
  Lines         10148    10150       +2     
  Branches       1408     1408              
============================================
+ Hits           5364     5366       +2     
  Misses         4341     4341              
  Partials        443      443
Impacted Files Coverage Δ Complexity Δ
Parse/src/main/java/com/parse/OfflineStore.java 4.61% <100%> (+0.34%) 5 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a314c5d...cc80892. Read the comment docs.

@hermanliang hermanliang merged commit bee0310 into parse-community:master May 8, 2017
@rogerhu
Copy link
Contributor

rogerhu commented May 8, 2017

Where did you see the bug?

@hermanliang
Copy link
Contributor Author

It's my fault. I not noticed this point when dealt with PR #607. It could be a potential problem with concurrent operations if map not synchronized. I think it's not serious because this logic is not often called.

@hermanliang hermanliang deleted the map-op-lock branch May 16, 2017 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants