Skip to content

Refactor ParseFieldOperations and give its own class #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

natario1
Copy link
Contributor

@natario1 natario1 commented Jun 1, 2017

I see no reason why ParseFieldOperation and ParseFieldOperations should be two classes in the same java file. This has no benefit, looks bad practice, and sometimes makes the build fail (it happens to me when I click on the test folder to run all the tests, with error along the lines of can’t find class ParseFieldOperations).

@codecov
Copy link

codecov bot commented Jun 1, 2017

Codecov Report

Merging #676 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #676   +/-   ##
=========================================
  Coverage     52.56%   52.56%           
- Complexity     1673     1678    +5     
=========================================
  Files           131      131           
  Lines         10106    10106           
  Branches       1405     1405           
=========================================
  Hits           5312     5312           
  Misses         4353     4353           
  Partials        441      441
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/com/parse/ParseFieldOperations.java 33.33% <33.33%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e53b1...e5a7764. Read the comment docs.

@Jawnnypoo
Copy link
Member

Personally, I think we should at some point also remove all the /* package */ comments at the beginning of source files, as it breaks the javadocs of the class. But that is another PR for another time

@natario1
Copy link
Contributor Author

natario1 commented Jun 1, 2017

Good point @Jawnnypoo , yes, let’s do that in a single PR for the whole SDK.

@natario1 natario1 merged commit d98f847 into parse-community:master Jun 1, 2017
@natario1 natario1 deleted the parsefieldoperations-class branch June 1, 2017 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants