Skip to content

Support global request batch size #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Support global request batch size #1053

merged 1 commit into from
Jan 8, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jan 7, 2020

Closes: #1045

Currently the /batch endpoint send multiple requests in the with the number of objects equal to batchSize (default 20). I believe batchSize was added to reduce server load during the parse.com days. Having batchSize will make result in a certain amount of overhead for your client.

This PR will allow you to decrease the number of requests which may result in saving resources and faster requests.

Closes: #1045

Currently the /batch endpoint send multiple requests in the with the number of objects equal to batchSize (default 20). I believe batchSize was added to reduce server load during the parse.com days. Having batchSize will make result in a certain amount of overhead for your client.

This PR will allow you to decrease the number of request which may result in saving resources.
@dplewis dplewis requested review from acinader and davimacedo January 7, 2020 23:52
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #1053 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
- Coverage   92.19%   92.19%   -0.01%     
==========================================
  Files          54       54              
  Lines        5152     5151       -1     
  Branches     1145     1145              
==========================================
- Hits         4750     4749       -1     
  Misses        402      402
Impacted Files Coverage Δ
src/CoreManager.js 100% <ø> (ø) ⬆️
src/ParseObject.js 89.43% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc6e5c...db76067. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Remove batchSize
2 participants