Skip to content

Fix user.become for AsyncStorage #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Fix user.become for AsyncStorage #1056

merged 2 commits into from
Jan 8, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jan 8, 2020

Closes: #1052

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #1056 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
- Coverage   92.19%   92.19%   -0.01%     
==========================================
  Files          54       54              
  Lines        5151     5150       -1     
  Branches     1145     1145              
==========================================
- Hits         4749     4748       -1     
  Misses        402      402
Impacted Files Coverage Δ
src/ParseUser.js 83.59% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac38333...8c1e874. Read the comment docs.

@dplewis dplewis requested review from acinader and davimacedo January 8, 2020 21:50
@dplewis dplewis merged commit 77e4068 into master Jan 8, 2020
@dplewis dplewis deleted the rn-before-fix branch January 8, 2020 22:35
@capacitivellc
Copy link

Has this been released?

@dplewis
Copy link
Member Author

dplewis commented Feb 17, 2020

Just check it hasn’t been release. We will do a release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

become() does not work on React Native
3 participants