-
-
Notifications
You must be signed in to change notification settings - Fork 598
Add Parse.CLP Object to control ClassLevelPermissions #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parse.CLP Object to control ClassLevelPermissions #1145
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 57 58 +1
Lines 5434 5645 +211
Branches 1219 1267 +48
==========================================
+ Hits 5434 5645 +211
Continue to review full report at Codecov.
|
This is very useful IMO. We had to manually do this ourselves. |
I found this problem to check permissions on CLP so i decide share my solutions, this is based on ACL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't look it up thoroughly.
@brunocosta91 thanks for the PR. It is a great job! I have some questions:
|
@davimacedo looks good to me. |
This weekend I will add more test and try improve PR with suggestions by @davimacedo |
@brunocosta91 Any updates on this? It would be awesome to include this in the SDK. Let us know if you need assistance. |
I will try get some time to improve this PR |
@brunocosta91 I can finish this PR up for you. I just need write access to your fork. This is an amazing feature! |
@davimacedo @mtrezza I believe this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The intent of this pull request is to provide the Parse.CLP object which could be use later to be returned on Parse.Schema.
Currently is possible create a new Parse.CLP(schema.classLevelPermissions) and check permissios of user/role/public.