Skip to content

Fix broken links in Readme #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Fix broken links in Readme #1236

merged 1 commit into from
Oct 22, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 22, 2020

Fixes: #646

Example: https://parseplatform.org/Parse-SDK-JS/api/2.17.0/

When deploying to gh-pages the relative links don't work because the files aren't included in the out.

@ghost
Copy link

ghost commented Oct 22, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #1236 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1236   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files          54       54           
  Lines        5331     5331           
  Branches     1203     1203           
=======================================
  Hits         4926     4926           
  Misses        405      405           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3070515...79e1c88. Read the comment docs.

@dplewis dplewis requested review from davimacedo and TomWFox October 22, 2020 19:59
@TomWFox TomWFox merged commit 41a8cc3 into master Oct 22, 2020
@TomWFox TomWFox deleted the readme-hardcode branch October 22, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API doc: link to v2 migration guide is broken
2 participants