Skip to content

Remove backbone callback documentation #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Remove backbone callback documentation #1239

merged 1 commit into from
Oct 24, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 23, 2020

Old backbone callbacks (options.success, options.error) are only used in linkWith authentication and object.set validation now.

i.e

object.set("currentPlayer", player2, {
  error: function(objectAgain, error) {
    // The set failed validation.
  }
});

Old backbone styles (options.success, options.errors) are only used in linkWith authentication and object.set validation now.
@ghost
Copy link

ghost commented Oct 23, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@dplewis dplewis requested a review from davimacedo October 23, 2020 23:34
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #1239 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
+ Coverage   92.38%   92.46%   +0.07%     
==========================================
  Files          54       54              
  Lines        5318     5308      -10     
  Branches     1202     1198       -4     
==========================================
- Hits         4913     4908       -5     
+ Misses        405      400       -5     
Impacted Files Coverage Δ
src/ParseGeoPoint.js 95.45% <ø> (ø)
src/ParseObject.js 90.94% <ø> (+0.44%) ⬆️
src/ParseQuery.js 96.06% <ø> (ø)
src/ParseUser.js 83.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b47ca...9c96b32. Read the comment docs.

@dplewis dplewis requested review from TomWFox and mtrezza October 24, 2020 03:12
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@dplewis dplewis merged commit 188074f into master Oct 24, 2020
@dplewis dplewis deleted the backbone-doc branch October 24, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants