Skip to content

Github Actions #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 4, 2020
Merged

Github Actions #1267

merged 8 commits into from
Dec 4, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Dec 3, 2020

No description provided.

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #1267 (da02623) into master (c89eec6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1267   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files          57       57           
  Lines        5405     5405           
  Branches     1199     1204    +5     
=======================================
  Hits         5404     5404           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c89eec6...da02623. Read the comment docs.

@dplewis dplewis requested a review from a team December 3, 2020 17:31
@dplewis
Copy link
Member Author

dplewis commented Dec 3, 2020

@davimacedo How does this look?

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dplewis great job! Just left a comment.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 17a2f0a into master Dec 4, 2020
@dplewis dplewis deleted the github-actions branch December 4, 2020 05:45
@davimacedo
Copy link
Member

I will try to remove Travis from being required

@dplewis
Copy link
Member Author

dplewis commented Dec 4, 2020

Thanks, I didn’t know the best way to remove it

@davimacedo
Copy link
Member

Found it. We should be good now.

@davimacedo
Copy link
Member

For reference: Settings -> Branches -> Branches Protection Rules > Edit Master

There you will find a list of checkboxes with all integrations for you to check which ones are required.

@dplewis
Copy link
Member Author

dplewis commented Dec 4, 2020

Thanks, the docs work

https://github.com/parse-community/Parse-SDK-JS/tree/gh-pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants