Fix prettier #1279
Merged
Fix prettier #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 5434 5434
Branches 1219 1219
=========================================
Hits 5434 5434 Continue to review full report at Codecov.
|
mtrezza
reviewed
Dec 13, 2020
| @@ -10,17 +10,17 @@ | |||
| // We need this until Jest finishes upgrading to Jasmine 2.0 | |||
| module.exports = function asyncHelper(fn) { | |||
| let finished = false; | |||
| const done = function() { | |||
| const done = function () { | |||
There was a problem hiding this comment.
I think we had that Lint discussion already, but the space between function and brackets is what we want?
There was a problem hiding this comment.
Yeah, technically you need a space before the name of the function. The name here is empty so the space should remain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding single quotes around the glob allows it to find subfolders in directories