Skip to content

Add useMasterKey option to Parse.File.destroy() #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2021
Merged

Add useMasterKey option to Parse.File.destroy() #1285

merged 2 commits into from
Jan 11, 2021

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jan 11, 2021

Closes: #1272

@codecov
Copy link

codecov bot commented Jan 11, 2021 •
edited
Loading

Codecov Report

Merging #1285 (dc74073) into master (a6bbd49) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1285   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        58           
  Lines         5645      5650    +5     
  Branches      1270      1273    +3     
=========================================
+ Hits          5645      5650    +5
Impacted Files Coverage Δ
src/ParseFile.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6bbd49...dc74073. Read the comment docs.

@dplewis dplewis requested review from davimacedo and mtrezza January 11, 2021 20:35
davimacedo
davimacedo approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis dplewis merged commit 1b60df4 into master Jan 11, 2021
@dplewis dplewis deleted the destroy-file branch January 11, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Documentation] MasterKey in Parse.File.destroy()
3 participants
@dplewis @davimacedo @mtrezza