Skip to content

docs: update equals method in ParseACL #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

JeffGuKang
Copy link
Contributor

@JeffGuKang JeffGuKang commented Jan 28, 2021

Original description didn't have type expression for a argument.

before

@param other The other object to compare to

after

@param {ParseACL} other The other object's ACL to compare to

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1288 (f102a42) into master (da702b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1288   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        58           
  Lines         5650      5650           
  Branches      1273      1273           
=========================================
  Hits          5650      5650           
Impacted Files Coverage Δ
src/ParseACL.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da702b2...f102a42. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis dplewis merged commit 0c84f19 into parse-community:master Jan 28, 2021
@JeffGuKang JeffGuKang deleted the docs/ParseACL-equals branch January 28, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants