Skip to content

[Snyk] Security upgrade ws from 7.4.5 to 7.4.6 #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2021

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 551/1000
Why? Recently disclosed, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS)
SNYK-JS-WS-1296835
No No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: ws The new version differs by 7 commits.
  • f5297f7 [dist] 7.4.6
  • 00c425e [security] Fix ReDoS vulnerability
  • 990306d [lint] Fix prettier error
  • 32e3a84 [security] Remove reference to Node Security Project
  • 8c914d1 [minor] Fix nits
  • fc7e27d [ci] Test on node 16
  • 587c201 [ci] Do not test on node 15

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #1370 (e4e8ed5) into master (0985f59) will not change coverage.
The diff coverage is n/a.

❗ Current head e4e8ed5 differs from pull request most recent head eb3421a. Consider uploading reports for the commit eb3421a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1370   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files          61       61           
  Lines        5941     5941           
  Branches     1349     1349           
=======================================
  Hits         5888     5888           
  Misses         52       52           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0985f59...eb3421a. Read the comment docs.

@dplewis dplewis merged commit 005321f into master May 27, 2021
@dplewis dplewis deleted the snyk-fix-1fe188e17288b9d12555085dd56e9220 branch May 27, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants