Skip to content

chore(LDS): Improve $relativeTime tests #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Sep 10, 2021

New Pull Request Checklist

Issue Description

Adding missing test cases from #1344

Will add to the server for LiveQuery.

Related issue: #FILL_THIS_OUT

Approach

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please check all required checkboxes at the top, otherwise your pull request will be closed.

  • ⚠️ Remember that a security vulnerability must only be reported confidentially, see our Security Policy. If you are not sure whether the issue is a security vulnerability, the safest way is to treat it as such and submit it confidentially to us for evaluation.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #1410 (647b3d2) into master (58bd796) will increase coverage by 0.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
+ Coverage   99.10%   99.81%   +0.70%     
==========================================
  Files          61       61              
  Lines        5943     5943              
  Branches     1350     1350              
==========================================
+ Hits         5890     5932      +42     
+ Misses         52       11      -41     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
src/OfflineQuery.js 100.00% <0.00%> (+13.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58bd796...647b3d2. Read the comment docs.

@dplewis dplewis merged commit 6578f7c into master Sep 10, 2021
@dplewis dplewis deleted the improve-relative-time-tests branch September 10, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants