Skip to content

refactor: Fix JSDoc warnings #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 1, 2023

Pull Request

Issue

Updating the jsdocs eslint plugin caused warning to shows. This PR addresses them.

see Issue

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 1, 2023

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 99.89% // Head: 99.89% // No change to project coverage 👍

Coverage data is based on head (9bce5c1) compared to base (f8c26d3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #1711   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          61       61           
  Lines        5984     5984           
  Branches     1372     1372           
=======================================
  Hits         5978     5978           
  Misses          6        6           
Impacted Files Coverage Δ
src/LiveQueryClient.js 98.99% <ø> (ø)
src/ParseObject.js 99.89% <ø> (ø)
src/ParseQuery.js 100.00% <ø> (ø)
src/ParseFile.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested a review from a team February 1, 2023 01:51
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title fix: JSDocs warnings refactor: Fix JSDoc warnings Feb 1, 2023
@mtrezza mtrezza merged commit 5805783 into parse-community:alpha Feb 1, 2023
@dplewis dplewis deleted the lint-jsdocs branch February 1, 2023 16:58
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.8

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 4, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 1, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.1.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants