Skip to content

test: Refactor tests to bump jest and jsdom to 29.4.1 #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 5, 2023

Pull Request

Issue

The newest version of Jest is lighter, faster and allows for cleaner unit tests

Closes: #1716, #1710

Approach

  • jsdom was removed from jest and needs to be installed separately
  • jest-jasmine2 was removed from jest so tests can't have both async/ await (return a promise) and done together
  • global node modules like setImmediate have been removed from jsdom
  • Add tests

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 5, 2023

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@dplewis dplewis changed the title Bump Jest and jsdom to 29.4.1 refactor: Bump Jest and jsdom to 29.4.1 Feb 5, 2023
@dplewis dplewis requested a review from a team February 5, 2023 01:42
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Base: 99.89% // Head: 99.90% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5366e3e) compared to base (febe187).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##            alpha    #1733    +/-   ##
========================================
  Coverage   99.89%   99.90%            
========================================
  Files          61       61            
  Lines        5992     6100   +108     
  Branches     1374     1482   +108     
========================================
+ Hits         5986     6094   +108     
  Misses          6        6            
Impacted Files Coverage Δ
src/uuid.js 100.00% <0.00%> (ø)
src/Parse.js 100.00% <0.00%> (ø)
src/unique.js 100.00% <0.00%> (ø)
src/ParseOp.js 100.00% <0.00%> (ø)
src/Storage.js 100.00% <0.00%> (ø)
src/ParseACL.js 100.00% <0.00%> (ø)
src/ParseCLP.js 100.00% <0.00%> (ø)
src/ParseFile.js 100.00% <0.00%> (ø)
src/ParseHooks.js 100.00% <0.00%> (ø)
src/ParseQuery.js 100.00% <0.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza changed the title refactor: Bump Jest and jsdom to 29.4.1 test: Bump Jest and jsdom to 29.4.1 Feb 5, 2023
@mtrezza
Copy link
Member

mtrezza commented Feb 5, 2023

I've changed the commit type to test.

@dplewis dplewis requested a review from mtrezza February 5, 2023 17:00
@mtrezza mtrezza changed the title test: Bump Jest and jsdom to 29.4.1 test: refactor tests to bump Jest and jsdom to 29.4.1 Feb 6, 2023
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title test: refactor tests to bump Jest and jsdom to 29.4.1 test: Refactor tests to bump Jest and jsdom to 29.4.1 Feb 6, 2023
@mtrezza mtrezza changed the title test: Refactor tests to bump Jest and jsdom to 29.4.1 test: Refactor tests to bump jest and jsdom to 29.4.1 Feb 6, 2023
@mtrezza mtrezza merged commit fa85d35 into parse-community:alpha Feb 6, 2023
@dplewis dplewis deleted the jest-29 branch February 6, 2023 16:56
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.12

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 6, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 1, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.1.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants