-
-
Notifications
You must be signed in to change notification settings - Fork 598
refactor: Convert CoreManager
to TypeScript
#2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2118 +/- ##
===========================================
+ Coverage 99.98% 100.00% +0.01%
===========================================
Files 61 64 +3
Lines 6185 6205 +20
Branches 1499 1504 +5
===========================================
+ Hits 6184 6205 +21
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. |
Type checking will be broken until ObjectStateMutations, ParsePush, ParseFile, ParseHook, ParseQuery, ParseUser are converted to TypeScript which will be done in the future. |
Parse.CoreManager
to TypeScriptCoreManager
to TypeScript
So should we make the type check job optional in the CI and merge this? |
How do you make it optional? |
@mtrezza I made type checking optional for now. This is good to merge |
I meant to remove the "required" option in the repo settings for that CI job. With your change the job will always pass in the CI, do we want that? |
@mtrezza I removed the CI change, do whatever you think is best. |
🎉 This change has been released in version 5.1.0-alpha.9 |
🎉 This change has been released in version 5.1.0-beta.1 |
🎉 This change has been released in version 5.1.0 |
Pull Request
Issue
Documentation missing from CoreManager.
Approach
Converting CoreManager to TypeScript will lay the foundation for future conversions. CoreManager will be the key to removing circular dependencies which is main issue when converting the entire project to TypeScript.