Skip to content

refactor: Convert CoreManager to TypeScript #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 3, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 2, 2024

Pull Request

Issue

Documentation missing from CoreManager.

Approach

Converting CoreManager to TypeScript will lay the foundation for future conversions. CoreManager will be the key to removing circular dependencies which is main issue when converting the entire project to TypeScript.

Copy link

parse-github-assistant bot commented May 2, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72bc9ac) to head (2665a78).
Report is 20 commits behind head on alpha.

Additional details and impacted files
@@             Coverage Diff             @@
##            alpha     #2118      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files          61        64       +3     
  Lines        6185      6205      +20     
  Branches     1499      1504       +5     
===========================================
+ Hits         6184      6205      +21     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team May 2, 2024 19:46
@dplewis
Copy link
Member Author

dplewis commented May 2, 2024

Type checking will be broken until ObjectStateMutations, ParsePush, ParseFile, ParseHook, ParseQuery, ParseUser are converted to TypeScript which will be done in the future.

@dplewis dplewis changed the title refactor: Convert Parse.CoreManager to TypeScript refactor: Convert CoreManager to TypeScript May 2, 2024
@mtrezza
Copy link
Member

mtrezza commented May 2, 2024

So should we make the type check job optional in the CI and merge this?

@dplewis
Copy link
Member Author

dplewis commented May 2, 2024

How do you make it optional?

@dplewis
Copy link
Member Author

dplewis commented May 2, 2024

@mtrezza I made type checking optional for now. This is good to merge

@mtrezza
Copy link
Member

mtrezza commented May 3, 2024

I meant to remove the "required" option in the repo settings for that CI job. With your change the job will always pass in the CI, do we want that?

@dplewis
Copy link
Member Author

dplewis commented May 3, 2024

@mtrezza I removed the CI change, do whatever you think is best.

@mtrezza mtrezza merged commit 1c50c37 into parse-community:alpha May 3, 2024
9 of 10 checks passed
@dplewis dplewis deleted the ts-coremanager branch May 3, 2024 21:02
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-alpha.9

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 4, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 16, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants