Skip to content

Perform user rewrite on Parse.Query #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2015
Merged

Perform user rewrite on Parse.Query #29

merged 1 commit into from
Sep 30, 2015

Conversation

andrewimm
Copy link
Contributor

Fixes #10

@andrewimm andrewimm added this to the 1.6.5 milestone Sep 29, 2015
@codecov-io
Copy link

Current coverage is 84.04%

Merging #29 into master will increase coverage by +0.05% as of 4fa053d

@@            master     #29   diff @@
======================================
  Files           37      37       
  Stmts         2743    2745     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           2304    2307     +3
  Partial          0       0       
+ Missed         439     438     -1

Review entire Coverage Diff as of 4fa053d

Powered by Codecov. Updated on successful CI builds.

@oriSomething
Copy link

it's compatible with old versions, but might be a good idea to use some deprecation API as in Ember or at least adding a console.warn for this issue

@andrewimm
Copy link
Contributor Author

@oriSomething This is simply correcting an oversight when we moved to the new codebase. We don't have plans to deprecate this behavior anytime soon -- it's just not thoroughly documented.

wangmengyan95
wangmengyan95 reviewed Sep 30, 2015
View reviewed changes
src/__tests__/ParseQuery-test.js
@@ -1289,4 +1289,13 @@ describe('ParseQuery', () => {
done();
});
}));

it('rewrites User queries when the rewrite is enabled', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we actually test two cases not only rewrite is enabled, so maybe change a name?
But really small nit, depends on you.

andrewimm added a commit that referenced this pull request Sep 30, 2015
@andrewimm
Merge pull request #29 from ParsePlatform/andrewi.user_rewrite_flag
a9b5f94 
Perform user rewrite on Parse.Query
@andrewimm andrewimm merged commit a9b5f94 into master Sep 30, 2015
@andrewimm andrewimm deleted the andrewi.user_rewrite_flag branch January 5, 2016 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrewimm andrewimm

Labels
None yet
Projects
None yet
Milestone
1.6.5
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewimm @codecov-io @oriSomething @wangmengyan95 @facebook-github-bot