Skip to content

Optimistically set ACLs from JSON blobs #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2015
Merged

Conversation

andrewimm
Copy link
Contributor

Fixes #23

@codecov-io
Copy link

Current coverage is 84.00%

Merging #30 into master will increase coverage by +0.01% as of 826213c

@@            master    #30   diff @@
=====================================
  Files           37     37       
  Stmts         2743   2745     +2
  Branches         0      0       
  Methods          0      0       
=====================================
+ Hit           2304   2306     +2
  Partial          0      0       
  Missed         439    439       

Review entire Coverage Diff as of 826213c

Powered by Codecov. Updated on successful CI builds.

@andrewimm andrewimm added this to the 1.6.5 milestone Sep 30, 2015
@wangmengyan95
Copy link
Contributor

Code LGTM, but why this cause other fields to become undefined?

@andrewimm
Copy link
Contributor Author

Validation is performed on every set(), and the default validation is to ensure that values in the ACL field are instanceof ParseACL. Cloud code performs an inner set() on beforeSave, so that the fields that were updated appear dirty within cloud code, but it was receiving a JSON-form ACL and failing that set.

andrewimm added a commit that referenced this pull request Sep 30, 2015
Optimistically set ACLs from JSON blobs
@andrewimm andrewimm merged commit cc8e12b into master Sep 30, 2015
@andrewimm andrewimm deleted the andrewi.set_acl_json branch January 5, 2016 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants