Skip to content

Expose error in _linkWith recursive call #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2015
Merged

Expose error in _linkWith recursive call #34

merged 2 commits into from
Oct 1, 2015

Conversation

wangmengyan95
Copy link
Contributor

When _linkWith is called recursively, we can not get the error thrown by the not first _linkWith call, as mentioned in #12 . This PR fixes this and add a test.

@codecov-io
Copy link

Current coverage is 84.75%

Merging #34 into master will increase coverage by +0.74% as of 8373f1c

@@            master     #34   diff @@
======================================
  Files           37      37       
  Stmts         2747    2748     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           2308    2329    +21
  Partial          0       0       
+ Missed         439     419    -20

Review entire Coverage Diff as of 8373f1c

Powered by Codecov. Updated on successful CI builds.

@wangmengyan95 wangmengyan95 force-pushed the wangmengyan.expose_linkWith_exception branch from 31b3b6e to f04f51f Compare September 30, 2015 21:23
andrewimm
andrewimm reviewed Sep 30, 2015
View reviewed changes
src/__tests__/ParseUser-test.js
deauthenticate() {}
};

ParseUser.logInWith(provider, {}).then(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can write .then(null, (error) => {}) instead if you don't intend to do anything with the first argument

@andrewimm
Copy link
Contributor

Style nit, but otherwise LGTM

@andrewimm andrewimm assigned wangmengyan95 and unassigned andrewimm Sep 30, 2015
@wangmengyan95 wangmengyan95 force-pushed the wangmengyan.expose_linkWith_exception branch from 0848bf4 to 69bcda9 Compare September 30, 2015 22:29
andrewimm added a commit that referenced this pull request Oct 1, 2015
@andrewimm
Merge pull request #34 from ParsePlatform/wangmengyan.expose_linkWith…
66cf20a 
…_exception

Expose error in _linkWith recursive call
@andrewimm andrewimm merged commit 66cf20a into master Oct 1, 2015
@andrewimm andrewimm added this to the 1.6.5 milestone Oct 1, 2015
@andrewimm andrewimm mentioned this pull request Oct 1, 2015
Closed
@andrewimm andrewimm deleted the wangmengyan.expose_linkWith_exception branch January 5, 2016 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.5
Development

Successfully merging this pull request may close these issues.
4 participants
@wangmengyan95 @codecov-io @andrewimm @facebook-github-bot