Skip to content

Addresses filename change in react-native library #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Addresses filename change in react-native library #440

merged 1 commit into from
Jun 5, 2017

Conversation

bshackelford
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jun 5, 2017

Codecov Report

Merging #440 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   84.49%   84.49%           
=======================================
  Files          46       46           
  Lines        3696     3696           
  Branches      846      846           
=======================================
  Hits         3123     3123           
  Misses        573      573
Impacted Files Coverage Δ
src/StorageController.react-native.js 85.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ba963...426721e. Read the comment docs.

@flovilmart
Copy link
Contributor

Let's merge that, I like how you updated the README as well

@flovilmart flovilmart merged commit ee5f997 into parse-community:master Jun 5, 2017
@bshackelford
Copy link
Contributor Author

Thanks @flovilmart 🙏

Will you be the one doing the release?

@flovilmart
Copy link
Contributor

I could well do one

@montymxb montymxb mentioned this pull request Jun 6, 2017
@pewh
Copy link

pewh commented Jun 14, 2017

Have anyone test this? Mine is throw an error

@bshackelford
Copy link
Contributor Author

@pewh If you are on a version of React Native less than 0.43 then this won't work; otherwise, it should be accurate based on facebook/react-native@cf1bc8d.

@flovilmart Any update on the release?

@pewh
Copy link

pewh commented Jun 15, 2017

My package.json

"parse": "parse-community/Parse-SDK-JS"
"react": "16.0.0-alpha.6"
"react-native": "^0.44.2"

and when start packager, it shows:

screenshot_2017-06-15_13-20-37

@bshackelford
Copy link
Contributor Author

@pewh Unfortunately you're not able to install the parse package from the repo like that since the lib directory isn't version controlled since it's part of the build/release process (which makes sense). A proper release should address the issue you're seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants