Addresses flaky test #458
Addresses flaky test #458
Conversation
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
=======================================
Coverage 85.39% 85.39%
=======================================
Files 46 46
Lines 3724 3724
Branches 854 854
=======================================
Hits 3180 3180
Misses 544 544Continue to review full report at Codecov.
|
|
@dplewis you may wanna have a look on this flaky test, odd that it runs locally properly :) |
|
@flovilmart Thanks for addressing this. I've been avoiding using .catch() and .fail() and only done.fail. Is |
|
No it’s in the JS SDK, it retired on errors, the skipped test works locally but not on the CI, or at least inconsistently. |
|
I see you have fixed a lot of flaky tests on JS SDK and parse server. Have you seen a pattern with inconsistent test? This would help with future tests. Does I try to follow this javascript guide for ES6 conventions. Maybe include this or something similar in CONTRIBUTION.md |
|
Skip comes from mocha yes, it let you keep a test in your suite explicitly skipping it. I don’t really understand why it sometimes fails, |
* Add Type Polygon to Schema and PolygonContains to query * Corrects Guide Link in README.md (#457) Just a small fix of `https` to `http` for the JS guide link, which is only available over `http`. * Addresses flaky test (#458) * Update ParseGeoPointTest.js * Limit request attempts to 1 * explore * Marks flaky test as pending * Add methods `addAll`, `addAllUnique` and `removeAll` (#459) * Add methods `addAll`, `addAllUnique` and `removeAll` * Add methods `addAll`, `addAllUnique` and `removeAll` * Add test for `addAll`, `addAllUnique` and `removeAll` * Revert test case * containsPoint uses bounded box first then ray casting * update parse-server to 2.6.0 * Add Type Polygon to Schema and PolygonContains to query * containsPoint uses bounded box first then ray casting * update parse-server to 2.6.0
No description provided.