Implemented PFObject.deleteAll through PFObjectBatchController. #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still needs some cleanup and tests, but the implementation is about as concrete as it would get. |
nlutsenko
force-pushed
the
nlutsenko.batch.delete
branch
from
1240bed to
11f2392
Compare
|
All done, waiting for you review. |
| NSDictionary *errorResult = result[@"error"]; | ||
| NSDictionary *successResult = result[@"success"]; | ||
|
|
||
| id<PFObjectControlling> controller = [[object class] objectController]; |
There was a problem hiding this comment.
Don't we have access to the data source here? Why go through the class dispatch method.
There was a problem hiding this comment.
Objects can have different object controllers, say UserController or InstallationController, where those have extra logic on top of the bare object controller.
nlutsenko
force-pushed
the
nlutsenko.batch.delete
branch
from
11f2392 to
6ced5df
Compare
| @@ -172,4 +257,21 @@ - (void)testUniqueObjectsValidation { | |||
| omitObjectsWithData:YES])); | |||
| } | |||
|
|
|||
| - (void)testUniqueObjectsUsingFilter { | |||
There was a problem hiding this comment.
Let's test the duplicate use case as well.
nlutsenko
force-pushed
the
nlutsenko.batch.delete
branch
2 times, most recently
from
7345ccc to
3359087
Compare
nlutsenko
force-pushed
the
nlutsenko.batch.delete
branch
from
3359087 to
69e5064
Compare
nlutsenko
added a commit
that referenced
this pull request
Aug 28, 2015
Implemented PFObject.deleteAll through PFObjectBatchController.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleteAllnot properly deleting objects from LDS, as well as not updating thedeletedproperty on state