Skip to content

Fix not automatically registered subclasses of built-in subclasses of PFObject. #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2016

Conversation

nlutsenko
Copy link
Contributor

@nlutsenko nlutsenko commented Jul 15, 2016

Use NSObject -conformsToProtocol:, which recursively checks whether a class conforms to protocol or not.

Fixes #975

@nlutsenko nlutsenko added this to the 1.14.1 milestone Jul 15, 2016
@nlutsenko nlutsenko merged commit 0c4f42b into master Jul 15, 2016
@nlutsenko nlutsenko deleted the nlutsenko.user.subclassing branch July 15, 2016 23:06
@rphlfc
Copy link

rphlfc commented Jul 20, 2016

I am having an error at PFObjectSubclassingController.m method _registerSubclassesInBundle line _registerSubclassesInBundle after updating to version 1.14.1. Had to go back to 1.13.0.

@kevflynn
Copy link

I'm seeing the same thing.

@kevflynn
Copy link

FYI @rphlfc - this commit, fixed this issue for me:
1.14.1...master
I manually added it.

@rphlfc
Copy link

rphlfc commented Jul 20, 2016

@kevflynn Thanks for sharing. I think I am going to stick with the 1.13.0 and wait till they release it. Thanks again.

PhilJacobsen pushed a commit to CrowdTunes/Parse-SDK-iOS-OSX that referenced this pull request Sep 12, 2016
* parseOriginal: (211 commits)
  Parse 1.14.2 ☁️ (parse-community#988)
  Fixed crash when an NSBundle without executable is loaded (parse-community#981)
  Parse 1.14.1 ☁️ (parse-community#977)
  Fix not automatically registered subclasses of built-in subclasses of PFObject. (parse-community#976)
  Parse 1.14.0 ☁️ (parse-community#973)
  Update xctoolchain to latest.
  Improve code coverage for PFFileState.
  Update Carthage dependencies.
  Update gem dependencies.
  Update PFObjectState.m (parse-community#922)
  Added automatic PFObject subclass registration. (parse-community#967)
  Fix non-faulted task when loading installationId from persistence group fails. (parse-community#970)
  Remove no longer required bitcode flag for iOS.
  Update Travis-CI configuration to use macOS name.
  Update Rakefile to use macOS instead of OSX.
  Update all gems to latest.
  Update xctoolchain to latest.
  Update all xcode configurations to latest.
  Update Carthage dependencies.
  Update starter projects to use configuration-based initialization API. (parse-community#957)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants