Skip to content

Error when attempting to update ParseFile #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2021
Merged

Error when attempting to update ParseFile #144

merged 2 commits into from
May 15, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented May 15, 2021

Should error when attempting to update a ParseFile that is already saved. It seems the parse-server doesn't support updating a ParseFile from the server tests (no PUT) and also from what's shown in the REST documentation. Instead another file should be created and the older file should be deleted later by the developer.

  • Remove updateFileCommand
  • Add testcases
  • Add changelog

@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #144 (534bbc9) into main (f1ddaab) will decrease coverage by 0.04%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   81.05%   81.01%   -0.05%     
==========================================
  Files          68       68              
  Lines        6362     6374      +12     
==========================================
+ Hits         5157     5164       +7     
- Misses       1205     1210       +5     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParseFile.swift 84.97% <71.42%> (-2.85%) ⬇️
Sources/ParseSwift/API/API+Commands.swift 79.55% <100.00%> (+1.50%) ⬆️
...t/LiveQuery/Protocols/ParseLiveQueryDelegate.swift 0.00% <0.00%> (-20.00%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 77.27% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ddaab...534bbc9. Read the comment docs.

@cbaker6 cbaker6 linked an issue May 15, 2021 that may be closed by this pull request
@cbaker6 cbaker6 merged commit b196fca into main May 15, 2021
@cbaker6 cbaker6 deleted the file branch May 15, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ParseFile with already known url
1 participant