Skip to content

Improve query comparison #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2021
Merged

Improve query comparison #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b6af4c
Improve docs
cbaker6 Jun 12, 2021
9e78458
Check pipeline and fields when comparing queries
cbaker6 Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
[Full Changelog](https://github.com/parse-community/Parse-Swift/compare/1.8.1...main)
* _Contributing to this repo? Add info about your change here to be included in the next release_

__Improvements__
- Ensure pipeline and fields are checked when comparing queries ([#163](https://github.com/parse-community/Parse-Swift/pull/163)), thanks to [Corey Baker](https://github.com/cbaker6).

### 1.8.1
[Full Changelog](https://github.com/parse-community/Parse-Swift/compare/1.8.0...1.8.1)

Expand Down
2 changes: 1 addition & 1 deletion Sources/ParseSwift/Parse.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public struct ParseConfiguration {
/**
Create a Parse Swift configuration.
- parameter applicationId: The application id of your Parse application.
- parameter clientKey: The client key of your Parse application..
- parameter clientKey: The client key of your Parse application.
- parameter masterKey: The master key of your Parse application.
- parameter serverURL: The server URL to connect to Parse Server.
- parameter liveQueryServerURL: The live query server URL to connect to Parse Server.
Expand Down
4 changes: 3 additions & 1 deletion Sources/ParseSwift/Types/Query.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,9 @@ public struct Query<T>: Encodable, Equatable where T: ParseObject {
lhs.readPreference == rhs.readPreference,
lhs.includeReadPreference == rhs.includeReadPreference,
lhs.subqueryReadPreference == rhs.subqueryReadPreference,
lhs.distinct == rhs.distinct else {
lhs.distinct == rhs.distinct,
lhs.pipeline == rhs.pipeline,
lhs.fields == rhs.fields else {
return false
}
return true
Expand Down