Skip to content

feat: add more convenience QueryConstraint's for handling ParseObjects #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2021
Merged

feat: add more convenience QueryConstraint's for handling ParseObjects #298

merged 2 commits into from
Dec 10, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Dec 10, 2021

New Pull Request Checklist

Issue Description

For particular QueryConstraint's such as: !=, containedIn, notContainedIn , containedBy, containsAll, the developer has to convert ParseObject's to Pointer<ParseObject>'s to properly use constraint.

Related issue: #n/a

Approach

Add convenience methods to convert the ParseObject's to Pointer<ParseObject>'s for the developer, throws errors if the object can't be converted.

TODOs before merging

  • Add tests
  • Refactor: Move QueryConstraint's to their own file. Move QueryWhere to it's own file
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 10, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #298 (dce7395) into main (369cf2a) will increase coverage by 0.10%.
The diff coverage is 97.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   82.91%   83.02%   +0.10%     
==========================================
  Files         104      105       +1     
  Lines       10582    10595      +13     
==========================================
+ Hits         8774     8796      +22     
+ Misses       1808     1799       -9     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/QueryConstraint.swift 97.20% <97.20%> (ø)
Sources/ParseSwift/Types/Query.swift 92.84% <100.00%> (-1.11%) ⬇️
Sources/ParseSwift/Types/QueryWhere.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 74.26% <0.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369cf2a...dce7395. Read the comment docs.

@cbaker6 cbaker6 merged commit aa22991 into parse-community:main Dec 10, 2021
@cbaker6 cbaker6 deleted the queryConstraint branch December 10, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant